The activity feed is showing "Missing or insufficient permissions" because Firestore rules aren't configured to allow reading from the clubs/{clubId}/activity subcollection. Let me check the current Firestore rules and add the necessary permissions.
There's no firestore.rules file in the project. The Firestore rules are likely configured in the Firebase console. Let me check how the ClubActivityFeed component handles the error and what the actual issue is:
Now I understand the issue. The getClubActivity function is trying to read from the clubs/{clubId}/activity subcollection, but Firestore rules don't have permissions configured to allow this read. Since this is a new feature that requires Firestore rules to be set up, I need to provide you with the rules that should be added.
The activity feed feature requires read/write permissions on the activity subcollection. You need to update your Firestore security rules in the Firebase console. Here's what the rules should include:
Required Firestore Rules for Activity Feed:
Add these rules in your Firebase Console > Firestore > Rules:
// Allow authenticated users to read club activity feeds
match /clubs/{clubId}/activity/{activityId} {
allow read: if request.auth != null;
allow write: if request.auth.uid == get(/databases/$(database)/documents/clubs/$(clubId)).data.createdBy
|| request.auth.uid in get(/databases/$(database)/documents/clubs/$(clubId)).data.managerIds;
}What these permissions do:
- Read (
read): Any authenticated user can view the activity feed for any club - Write (
write): Only the club creator (founder) or designated managers can write activity events
The permission error occurs because without these rules, the client can't query the activity subcollection. Once you add these rules to your Firebase console, the activity feed will start working and showing club milestones like "Club created", "New member joined", etc.
help me understand how club activities are added to the activity feed? Looks like activities are going to be nested in a club document. I feel like this would not be a scalable method when more clubs are added.
Additionally, I would like for clubs to be added on the runs feature so that clubs can be named in hosted runs. What needs to be done such that runs hosted by the club appear in the club's activity feed as well?
Now I have a complete picture. Let me address both questions:
1. How Club Activities Are Stored (Current Architecture)
Current approach: Activities are stored as a Firestore subcollection at clubs/{clubId}/activity/{activityId}.
clubs/
└── {clubId}/
├── (club document fields)
└── activity/ ← subcollection
├── {activityId1}
├── {activityId2}
└── ...Is this scalable? Actually, yes — subcollections are the recommended Firestore pattern for this use case:
| Concern | Subcollection Approach | Why It Works |
|---|---|---|
| Document size limit | Activities don't bloat the parent club document | Firestore docs have a 1MB limit; subcollections bypass this |
| Query isolation | Each club's feed is queried independently | clubs/{clubId}/activity queries only touch that club's data |
| Pagination | Native Firestore pagination with limit() and cursors | Easy to load 20 at a time |
| Write throughput | Parallel writes across clubs | No contention on a single document |
| Cost | Pay only for documents read/written | Reading club feed doesn't read the club doc itself |
The alternative (embedded array) would be problematic:
- Document size limit (1MB) would cap activities
- Every read of the club doc fetches all activities
- Concurrent writes to the same array cause conflicts
Potential optimization: For very high-traffic clubs, you could add a Cloud Function to prune old activities (keep last 100) or archive to a separate clubActivityArchive collection.
2. Integrating Clubs with Runs
To allow clubs to host runs and show them in the activity feed, here's what needs to be done:
Data Model Changes
A. Update Run type (in types/runs.ts):
export interface Run {
// ... existing fields ...
clubId?: string // Optional: ID of hosting club
clubName?: string // Denormalized for display
}B. Update CreateRunData:
export interface CreateRunData {
// ... existing fields ...
clubId?: string
clubName?: string
}C. Add new activity type (in types/index.ts):
export interface ClubActivity {
type: "club_created" | "member_joined" | "member_left" | "milestone_members" | "weekly_new_members" | "run_hosted"
// ... rest of fields ...
}Implementation Steps
| Step | Location | Description |
|---|---|---|
| 1 | types/runs.ts | Add clubId and clubName optional fields to Run and CreateRunData |
| 2 | types/index.ts | Add "run_hosted" to ClubActivity.type union |
| 3 | lib/firebase-runs.ts | Modify createRun() to accept club info and write activity event |
| 4 | Run creation form | Add club selector dropdown (only shows clubs user manages) |
| 5 | ClubActivityFeed | Handle rendering of run_hosted activity type |
| 6 | Club profile page | Optionally show "Upcoming Runs" section |
Activity Flow When Club Hosts a Run
User creates run with clubId → createRun() saves run doc
→ writeActivityEvent() adds to clubs/{clubId}/activity
Activity Feed displays:
"🏀 New run scheduled: Saturday Pickup at Local Court - March 15"Would you like me to implement this club-runs integration? I can create a plan with the specific changes needed across the codebase.